Possibly a simpler reproducer for #323 #326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaze
force-pushed
the
spaze/reproducer-323-v2
branch
from
abb05ab to
fcc14fc
Compare
staabm
reviewed
Apr 18, 2025
| use PHPStan\Rules\Rule; | ||
| use PHPStan\Testing\RuleTestCase; | ||
|
|
||
| class Reproducer2Test extends RuleTestCase |
There was a problem hiding this comment.
If I read this test correctly it is now independent from the disallowed-calls extension package, right?
if so, I think we should open a phpstan-src issue and add the reproducer there
There was a problem hiding this comment.
I will port it over into the fixing PR at phpstan/phpstan-src#3944
There was a problem hiding this comment.
Perfect, and yes, it is independent now.
|
This helped fix #323 but can be closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.